This repository has been archived by the owner on Sep 25, 2024. It is now read-only.
adding patch to fix declaration of normalize function being not compa… #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeniatencio
added
DO NOT REVIEW
DO NOT MERGE
Needs Review
and removed
DO NOT REVIEW
DO NOT MERGE
labels
yeniatencio
requested review from
anthony-malkoun,
vincent-gao and
MdNadimHossain
anthony-malkoun
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Hi @yeniatencio this is fine, but also please add comments to the issue and review so we can help get it merged into the release.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content reference build in develop environment is failing because declaration of the normalize function is incompatible with normalize function return type after Schemata 8.x-1.0 was released.
https://github.com/dpc-sdp/tide_api/actions/runs/10282085221/job/28453007763#step:8:3557
Issue: https://www.drupal.org/project/jsonapi_extras/issues/3473990
Solution:
Screenshot.
JIRA issue: https://digital-vic.atlassian.net/browse/SDPAP-
Changed
Screenshots