Remove the install hook. #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnykt
suggested changes
May 5, 2021
| /** | ||
| * Enable tide_edit_protection module. | ||
| */ | ||
| function tide_core_update_8046() { |
There was a problem hiding this comment.
@vincent-gao this update hook was released in 2.0.8 so you can't remove it. The body of the hook can be removed. but the hook itself must stay.
There was a problem hiding this comment.
@sonnykt sure. indeed it should keep same number with database.
vincent-gao
force-pushed
the
feature/remove_installation_of_tide_edit_protection
branch
from
cc140c9
to
6f81dff
Compare
sonnykt
approved these changes
May 6, 2021
vincent-gao
deleted the
feature/remove_installation_of_tide_edit_protection
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
dpc-sdp/baywatch#24