[SDPAP-7077] Related link mandatory and help text. #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…change-link-text-field-to-mandatory
edyuenyw
requested review from
MdNadimHossain,
vincent-gao,
anthony-malkoun,
mayurngondhkar and
yeniatencio
and removed request for
MdNadimHossain
MdNadimHossain
approved these changes
Feb 1, 2023
vincent-gao
reviewed
Feb 1, 2023
| $link_config->set('description', $link_description); | ||
| $link_config->set('settings.title', $systems); | ||
| $link_config->save(); | ||
| } |
There was a problem hiding this comment.
hey @edyuenyw
The above looks too complicated. you probably just want to load the active field.field.paragraph.related_links.field_paragraph_link and change the description and title directly.
There was a problem hiding this comment.
Thanks @vincent-gao,
Change made. Less is more 😄
…xt-field-to-mandatory' of github.com:dpc-sdp/tide_core into feature/SDPAP-7077-core-be-related-links-change-link-text-field-to-mandatory
edyuenyw
deleted the
feature/SDPAP-7077-core-be-related-links-change-link-text-field-to-mandatory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://digital-vic.atlassian.net/browse/SDPAP-7077
Problem/Motivation
In this component, the URL field is mandatory. But the Link text field is currently not mandatory. The Link text field needs to be mandatory in order for the link to display.
If a CMS user fills the URL field but not the Link text field, they are able to save the node/page OK but on the front end, if there is no content in the Link text field, no link will display.
Fix
Related PRs
BE: https://github.com/dpc-sdp/content-reference-sdp-vic-gov-au/pull/202 | https://nginx-php.pr-202.content-reference-sdp-vic-gov-au.sdp4.sdp.vic.gov.au/
Screenshots
Before:
After:
TODO