Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDPAP-8359] increase character limit for url field #441

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

vincent-gao
Copy link
Contributor

@vincent-gao vincent-gao commented Oct 11, 2023

Jira

SDPAP-8359 Embed tool - increase character limit for URL field

Change

increase #maxlength to 512, which should be enough.

@vincent-gao vincent-gao changed the title [SDPAP-8359] increase character limit for urlfield [SDPAP-8359] increase character limit for url field Oct 11, 2023
@vincent-gao vincent-gao self-assigned this Oct 11, 2023
Copy link
Contributor

@krakerag krakerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Maybe the testers can get a functional test going for this one also to make sure we don't regress etc.

@vincent-gao vincent-gao force-pushed the feature/SDPAP-8359-increase-character-limit branch from 3a22a4a to b05860c Compare March 22, 2024 05:54
### Jira
[SDPAP-8359] Embed tool - increase character limit for URL field

### Change
simply increase #maxlength to 512, which should be enough.
@vincent-gao vincent-gao force-pushed the feature/SDPAP-8359-increase-character-limit branch from b05860c to 1dd7af9 Compare March 22, 2024 05:55
@vincent-gao vincent-gao merged commit 8abb168 into develop Mar 22, 2024
2 of 5 checks passed
@vincent-gao vincent-gao deleted the feature/SDPAP-8359-increase-character-limit branch March 22, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants