[SDPAP-7103] Enable bulk publishing for Approvers #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Jira https://digital-vic.atlassian.net/browse/SDPAP-7103 ### Change The update includes the implementation of the `tide node bulk update` permission and the necessary code changes.
vincent-gao
force-pushed
the
feature/SDPAP-7103-Bulk-publishing-for-Approvers
branch
from
4c514a1
to
bced6af
Compare
vincent-gao
requested review from
krakerag,
anthony-malkoun and
MdNadimHossain
vincent-gao
force-pushed
the
feature/SDPAP-7103-Bulk-publishing-for-Approvers
branch
from
bced6af
to
127a394
Compare
krakerag
reviewed
Oct 12, 2023
dev-tools.sh
Outdated
| @@ -33,6 +33,6 @@ | |||
| # stable version. | |||
| # | |||
| # Uncomment and set the Dev-Tools's commit value and commit this change. | |||
| # export GH_COMMIT=COMMIT_SHA | |||
| export GH_COMMIT=4522e05d991e675aa80dfbc6e7a471896f3f6d81 | |||
There was a problem hiding this comment.
Do we need this reverted?
There was a problem hiding this comment.
yes, it will be reverted.
| Given I am logged in as a user with the "<role>" role | ||
| Then I should find menu item text matching "CMS Support" | ||
| Examples: | ||
| scenario outline: user logs into the cms and clicks on the manage tab |
There was a problem hiding this comment.
Did some filter go over this to make it all lowercase? Looks weird :)
There was a problem hiding this comment.
yeah, not sure why seems like an accidental commit. deleted.
vincent-gao
force-pushed
the
feature/SDPAP-7103-Bulk-publishing-for-Approvers
branch
from
127a394
to
341ee9d
Compare
vincent-gao
force-pushed
the
feature/SDPAP-7103-Bulk-publishing-for-Approvers
branch
from
341ee9d
to
99bb462
Compare
|
hey @krakerag , the dev-tools change has been reverted. I think the PR is now ready to be merged. |
krakerag
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://digital-vic.atlassian.net/browse/SDPAP-7103
Change
The update includes the implementation of the
tide node bulk updatepermission and the necessary code changes.Related PR