Fixes the issue where CKE 5 Interface not loading #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-gao
requested review from
krakerag,
anthony-malkoun and
MdNadimHossain
hey @anthony-malkoun, There is no patch file available on Drupal.org, only a PR. https://git.drupalcode.org/project/entity_embed/-/merge_requests/26 |
|
Having a static patch is better than the PR, which can change. Is our pattern to store a patch on drupal.org or locally? Whichever the chosen pattern is, lets match that. |
|
hey @krakerag |
anthony-malkoun
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem/Motivation
https://www.drupal.org/project/entity_embed/issues/3272732 has been merged, but it introduces a new issue to Drupal 9, where CKEditor 5 Interface is not loading on text formats using entity embed.
Fix
https://www.drupal.org/project/entity_embed/issues/3396133
https://git.drupalcode.org/project/entity_embed/-/merge_requests/26/diffs