Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDPAP-8538] Fixes last update date issue #469

Merged
merged 1 commit into from
Apr 8, 2024
Merged

[SDPAP-8538] Fixes last update date issue #469

merged 1 commit into from
Apr 8, 2024

Conversation

vincent-gao
Copy link
Contributor

@vincent-gao vincent-gao commented Jan 29, 2024 •
edited
Loading

Jira

https://digital-vic.atlassian.net/browse/SDPAP-8538

Problem/Motivation

  1. for this specific version of entity_embed, it doesn't support well for the wildcard, so let's just explicitly specify all tags we need.
  2. other issues are detailed in https://www.drupal.org/project/entity_embed/issues/3410132
  3. it should be noted that this is only a temporary solution.

Fix

https://www.drupal.org/project/entity_embed/issues/3410132#comment-15418003

@vincent-gao vincent-gao force-pushed the feature/SDPAP-8538-Fixes-Last-update-date-issue branch from de78fc9 to ebd2ada Compare January 29, 2024 05:51
@vincent-gao vincent-gao self-assigned this Jan 29, 2024
@vincent-gao vincent-gao removed the request for review from krakerag March 22, 2024 05:11
@vincent-gao vincent-gao force-pushed the feature/SDPAP-8538-Fixes-Last-update-date-issue branch from ebd2ada to 2995dab Compare March 22, 2024 05:37
yeniatencio
yeniatencio approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@yeniatencio yeniatencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vincent-gao vincent-gao force-pushed the feature/SDPAP-8538-Fixes-Last-update-date-issue branch from 10f2e4e to 6da82ee Compare April 8, 2024 07:23
@vincent-gao vincent-gao merged commit e295654 into develop Apr 8, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeniatencio yeniatencio yeniatencio approved these changes

@mayurngondhkar mayurngondhkar Awaiting requested review from mayurngondhkar

@MdNadimHossain MdNadimHossain Awaiting requested review from MdNadimHossain

Assignees

@vincent-gao vincent-gao

Labels
Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent-gao @yeniatencio