Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed hook #478

Merged
merged 3 commits into from
Mar 6, 2024
Merged

fixed hook #478

merged 3 commits into from
Mar 6, 2024

Conversation

yeniatencio
Copy link
Contributor

@yeniatencio yeniatencio commented Mar 6, 2024

Jira

Problem/Motivation

Content-reference build was failing because hook update wrong configs files

Fix

Update hook update

Related PRs

Screenshots

Screenshot 2024-03-06 at 3 04 04 pm

TODO

Copy link
Contributor

@MdNadimHossain MdNadimHossain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yeniatencio the previous step was right, just need a slight modification, try like this - https://github.com/dpc-sdp/baywatch/blob/master/src/BaywatchOperation.php#L92
check first if the field exist, if it returns null then only createFromStorageRecord

@yeniatencio yeniatencio merged commit b2a0765 into develop Mar 6, 2024
4 of 6 checks passed
@yeniatencio yeniatencio deleted the fix/update-config-files branch March 6, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants