Update token version #498
Merged
Update token version #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeniatencio
requested review from
MdNadimHossain,
anthony-malkoun and
vincent-gao
vincent-gao
requested changes
Jul 29, 2024
There was a problem hiding this comment.
hey @yeniatencio
Thanks for the changes.
I think we should not limit the version to a specific old version, especially when the latest version has passed the Drupal security tests. Please keep it at ^1.11 and update the patch.
vincent-gao
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://digital-vic.atlassian.net/browse/SD-134
Problem/Motivation
Patch doesn't apply in the last version of token as the code has been refactored. Therefore, downgrading to version 12 and update to latest available version of the patch.
Fix
https://www.drupal.org/project/token/issues/2924873#comment-15705267
Related PRs
Screenshots
TODO