Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for KafkaAdminClient #1648

Open
jeffwidman opened this issue Nov 18, 2018 · 1 comment
Open

Add tests for KafkaAdminClient #1648

jeffwidman opened this issue Nov 18, 2018 · 1 comment

Comments

@jeffwidman
Copy link
Collaborator

jeffwidman commented Nov 18, 2018

I need to add tests for the KafkaAdmin changes I made:

  1. Stop using broker-errors for client-side problems #1639
  2. Fix KafkaAdmin send to controller #1640
  3. Add group coordinator lookup #1641
  4. Fix describe groups #1642
  5. Add list consumer groups offsets #1643
  6. Set a clear default value for validate_only / include_synonyms #1645

I didn't have time yet to do tests... Given that the existing KafkaAdminClient code currently on the master branch is broken, sometimes in subtle ways, I decided fine to put them up as-is since then the code will be mostly working, and then later add tests to prevent regressions.

Frankly, the test fixtures are a bit of a mess, so I will probably instead go the route of finishing #1193, as that will both simplify the code drastically and require a few fixture changes.

And then after that tackle the tests/missing coverage.

But creating this and assigning it to myself so that I don't forget

@jeffwidman jeffwidman self-assigned this Nov 18, 2018
@jeffwidman jeffwidman changed the title Add tests for the KafkaAdmin changes I made Add tests for the KafkaAdminClient changes I made Nov 20, 2018
@dpkp dpkp changed the title Add tests for the KafkaAdminClient changes I made Add tests for the KafkaAdminClient changes jeffwidman made Nov 23, 2018
@jeffwidman jeffwidman changed the title Add tests for the KafkaAdminClient changes jeffwidman made Add tests for KafkaAdminClient Feb 12, 2020
@jeffwidman jeffwidman removed their assignment Feb 12, 2020
@jeffwidman
Copy link
Collaborator Author

I am unlikely to get to this as my day job no longer involves Kafka.

PR's welcome if anyone is interested!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant