Set a clear default value for validate_only / include_synonyms
#1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
changed the title
validate_onlyvalidate_only / include_synonyms
jeffwidman
force-pushed
the
be-explicit-with-validate_only
branch
from
ca51544
to
0288f48
Compare
jeffwidman
force-pushed
the
be-explicit-with-validate_only
branch
from
0288f48
to
a2fcbc2
Compare
Set a clear default value for `validate_only` / `include_synonyms` Previously the kwarg defaulted to `None`, but then sent a `False` so this makes it more explicit and reduces ambiguity.
jeffwidman
force-pushed
the
be-explicit-with-validate_only
branch
from
a2fcbc2
to
b11eeeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set a clear default value for
validate_only/include_synonymsPreviously the kwarg defaulted to
None, but then sent aFalseso this just makes it more explicit and reduces ambiguity.This change is