Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests migration to pytest framework #1293

Merged
merged 4 commits into from
Feb 21, 2018
Merged

Integration tests migration to pytest framework #1293

merged 4 commits into from
Feb 21, 2018

Commits on Feb 13, 2018

  1. Update string representation of SimpleClient

    @asdaraujo
    asdaraujo committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    e456d1a View commit details
    Browse the repository at this point in the history

  2. Check timeout type in KafkaClient constructor 

    If a future was passed as the only positional parameter it would
be assigned to the "timeout_ms" parameter erroneously. This mistake
would not raise any exception but would lead to odd behaviour later,
what could make it extremely difficult to troubleshoot.

Adding a type check ensures that an exception is raise earlier to
notify the user about the problem.
    @asdaraujo
    asdaraujo committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    5569644 View commit details
    Browse the repository at this point in the history

  3. Introduce new fixtures to prepare for migration to pytest. 

    This commits adds new pytest fixtures in prepation for the
migration of unittest.TestCases to pytest test cases. The handling
of temporary dir creation was also changed so that we can use
the pytest tmpdir fixture after the migration.
    @asdaraujo
    asdaraujo committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    c2ed222 View commit details
    Browse the repository at this point in the history

  4. Fixes racing condition when message is sent to broker before topic lo… 

    …gs are created
    @asdaraujo
    asdaraujo committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    c65c400 View commit details
    Browse the repository at this point in the history