Change SimpleProducer to use async_send (async is reserved in py37) #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
approved these changes
Mar 23, 2018
Closed
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Aug 1, 2018
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Aug 1, 2018
|
Has this fix been integrated into a kafka-python release? The documentation page still indicates python-kafka is only compatible with 3.6 and lower. |
|
It has been merged, yes. But we have not successfully configured the travis
test suite to run on python 3.7. Once that happens and we have automated
3.7 testing, then I will feel more comfortable declaring compatibility.
|
charettes
pushed a commit
to zapier/kafka-python
that referenced
this pull request
Jun 26, 2019
charettes
pushed a commit
to zapier/kafka-python
that referenced
this pull request
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asyncis a reserved word in python 3.7. I've renamed the SimpleProducer async toasync_sendand updated the docs. Applications that passasync=will get a deprecation warning in the logs but we'll continue to allow for now by checking **kwargs.Ref #1451