Be explicit with tuples for %s formatting #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
force-pushed
the
use-explicit-tuples-for-strings
branch
from
6aecd54
to
91facfd
Compare
tvoinarovskyi
approved these changes
Nov 13, 2018
tvoinarovskyi
previously requested changes
Nov 13, 2018
|
1 place failed the another 2 eyes test =) |
|
Looks fine w/ the one modulo issue taras noted. I think |
jeffwidman
force-pushed
the
use-explicit-tuples-for-strings
branch
from
91facfd
to
e2b7102
Compare
|
Good catch @tvoinarovskyi, I fixed. |
jeffwidman
force-pushed
the
use-explicit-tuples-for-strings
branch
from
e2b7102
to
8eb26b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1633
I think I got them all... I would appreciate another pair of eyes to review that I didn't accidentally make mistakes on this.
This is a bit hideous, and definitely overkill, but it's faster than trying to debug
TypeErrors in production...Alternatively, could switch these to
.format().Unfortunate that the lovely new python 3.7 syntax f-strings are not backport-able.
This change is