Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using broker-errors for client-side problems #1639

Merged
merged 1 commit into from
Nov 18, 2018

Commits on Nov 18, 2018

  1. Stop using broker-errors for client-side problems

    `UnsupportedVersionError` is intended to indicate a server-side error:
    https://github.com/dpkp/kafka-python/blob/ba7372e44ffa1ee49fb4d5efbd67534393e944db/kafka/errors.py#L375-L378
    
    So we should not be raising it for client-side errors. I realize that
    semantically this seems like the appropriate error to raise. However,
    this is confusing when debugging... for a real-life example, see
    Parsely/pykafka#697. So I strongly feel that
    server-side errors should be kept separate from client-side errors,
    even if all the client is doing is proactively protecting against
    hitting a situation where the broker would return this error.
    jeffwidman committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    aad278f View commit details
    Browse the repository at this point in the history