New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement eq and hash for ACL objects #1955

Merged

dpkp merged 2 commits into dpkp:master from TylerLubeck:acl_comparison

Dec 29, 2019

Contributor

TylerLubeck commented Nov 15, 2019 •

edited by dpkp

Loading

This allows for direct comparison of ACL objects, and allows us to create sets of them

I've found it useful for some work I'm doing to allow us to manage ACLs in some source-controlled way

read the 'expected' ACLs from the source controlled file, create ACL objects
fetch all 'current' ACLs from kafka
create set objects of both
Do set operations to determine what commands I need to run to bring kafka in sync with the expected ACL configurations

This change is

Tyler Lubeck added 2 commits

November 15, 2019 10:29


          Implement __eq__ and __hash__ for ACL objects

458d63b

This allows for direct comparison of ACL objects, and allows us to
create `set`s of them


          Add tests for ACL comparisons

aa5c7e9

dpkp approved these changes

View reviewed changes

dpkp merged commit bc25877 into dpkp:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet