Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise AssertionError if consumer closed in poll() #1978

Merged
merged 2 commits into from
Dec 30, 2019
Merged

Raise AssertionError if consumer closed in poll() #1978

merged 2 commits into from
Dec 30, 2019

Conversation

dpkp
Copy link
Owner

@dpkp dpkp commented Dec 29, 2019 •
edited
Loading

Fixes #1219

This change is Reviewable

@dpkp dpkp requested a review from jeffwidman December 29, 2019 16:46
@dpkp dpkp mentioned this pull request Dec 29, 2019
Closed
@dpkp dpkp merged commit 23534b4 into master Dec 30, 2019
@dpkp dpkp deleted the issue-1219-closed-consumer branch December 30, 2019 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffwidman jeffwidman Awaiting requested review from jeffwidman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should consumer.poll() first verify the consumer isn't closed?
1 participant
@dpkp