attention mask & bias #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guolinke
reviewed
Oct 12, 2022
guolinke
reviewed
Oct 12, 2022
guolinke
reviewed
Oct 12, 2022
guolinke
reviewed
Oct 12, 2022
guolinke
reviewed
Oct 12, 2022
guolinke
reviewed
Oct 12, 2022
guolinke
reviewed
Oct 12, 2022
| Gmem_tile_bias gmem_bias(params, binfo, tidx, loop_step_idx); | ||
|
|
||
| using Gmem_tile_ds = typename Kernel_traits::Gmem_tile_ds; | ||
| Gmem_tile_ds gmem_ds(params, binfo, tidx, loop_step_idx); |
There was a problem hiding this comment.
ds should be disable during forward?
There was a problem hiding this comment.
yes, this part is for backward.
guolinke
reviewed
Oct 12, 2022
guolinke
reviewed
Oct 12, 2022
guolinke
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add attention mask & bias.
Currently, because of the ldg instruction problem, we only support an even number of sequence lengths.