Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for AC mode #292

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Add icon for AC mode #292

merged 2 commits into from
Oct 7, 2024

Conversation

fvincenzo
Copy link
Contributor

If tmux theme is run on a desktop the battery space is empty.
Restore the previous behavior displaying AC and an icon.

@Theoreticallyhugo
Copy link
Contributor

heya mate,
that sounds like a good idea.
however, i'd love to see some configurability allowing users to use dracula without nerd-fonts too.
while i prefer nerdfonts, i think being able to use it without them is important.
(if youre not using a nerd-font symbol and its just github being unable to display it, i apologise and approve your changes)

@fvincenzo
Copy link
Contributor Author

fvincenzo commented Sep 20, 2024

Hello,

thank you for your review.

Yes I am using nerd font and the battery plugin (even all the others) use nerd font symbols for everything. I am not sure I understand what you want me to do 😄

Apologize if it is me not getting the concept.

[Edit: I think I got the idea 👍]

Note: I improved the documentation and fixed a bug in the process.

Make it configurable via @dracula-no-battery-label
In bash everything is a string, boolean check must be explicit.
@Theoreticallyhugo
Copy link
Contributor

Awesome!
in the process of writing more documentation for this plugin, im planning on including example configs for people with and without nerd-fonts. if you'd like, you can comment your preferred icon for the no-battery icon, and i'll put it in the docs.

Thanks a lot for your contribution :D

@fvincenzo
Copy link
Contributor Author

fvincenzo commented Sep 20, 2024

My prefererred config with nerd font is:

set -g @dracula-no-battery-label " AC"

without:

set -g @dracula-no-battery-label "AC"

If you need help with anything let me know. I use the theme on daily basis, happy to contribute back if needed.

P.S. Let me know when you merge my changes so that I can switch back to the official repo (currently using my fork with the patches).

@fvincenzo
Copy link
Contributor Author

fvincenzo commented Oct 7, 2024

Hello,

Is this patch ready to be merged? Or do I need to do anything else?

Thanks!

@ethancedwards8 ethancedwards8 merged commit 74e07c7 into dracula:master Oct 7, 2024
1 check passed
@ethancedwards8
Copy link
Member

You're good to go, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants