Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust editor.selectionBackground & editor.selectionHighlightBackground #183

Open
wenfangdu opened this issue Jul 3, 2021 · 3 comments · Fixed by #253
Open

Adjust editor.selectionBackground & editor.selectionHighlightBackground #183

wenfangdu opened this issue Jul 3, 2021 · 3 comments · Fixed by #253

Comments

@wenfangdu
Copy link

wenfangdu commented Jul 3, 2021

Currently, these two colors are almost indistinguishable, more contrast would be better.

image

Can't tell statusBar with the cursor is selected or not:

image

@dsifford
Copy link
Member

dsifford commented Aug 2, 2021

I tried playing with this for a bit just now and it's unfortunately not as simple as just adjusting those two regions.

This gets tricky, particular in "smarter" synataxes (like javascript, for example) because editor.wordHighlightBackground and editor.wordHighlightStrongBackground seem to also play a role in this and that role appears to be of a higher priority.

So I'm not sure there is an easy fix. Feel free to propose a solution if you have one.

@wenfangdu
Copy link
Author

@dsifford Fixing #184 would partially solve this issue.

As for

This gets tricky, particularly in "smarter" syntaxes (like javascript, for example) because editor.wordHighlightBackground and editor.wordHighlightStrongBackground seem to also play a role in this and that role appears to be of a higher priority.

We can fix this later if a better solution is raised.

@luxonauta luxonauta linked a pull request Jul 17, 2024 that will close this issue
@wenfangdu wenfangdu mentioned this issue Jul 18, 2024
@wenfangdu
Copy link
Author

@dsifford @luxonauta @zenorocha Please reopen this issue, since #253 has been reverted.

@dsifford dsifford reopened this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants