🌱 v2.25.0 #253

luxonauta · 2024-07-17T01:44:32Z

Removed the Soft variant (prepares the ground for us to introduce the Light variant for the Classic in the future);
Introduced new colour settings for Editor Marker Navigation, Peek View Colors, Command Center, and Notification Colors, enhancing customization and visibility.
Significant adjustments to various editor components, including the Diff Editor, Inline Chat, Editor Widgets, Editor Suggest Widget, Editor Hover Widget, and Debug Exception Widget, ensuring a more cohesive and consistent experience;
Improvements to various metascopes, increasing the accuracy and clarity of the interface;
Addressed edge cases for different languages and log file entries, ensuring expanded compatibility and functionality.

Note: This update brings the Dracula Theme closer to what we have in Dracula PRO and thus facilitates support for both; it also prepares us to introduce the Light variant for the Classic in the future.

dsifford · 2024-07-17T10:51:08Z

@luxonauta I do not agree with your aggressiveness here. Who approved this?

luxonauta · 2024-07-17T10:55:55Z

Hey 👋🏻 @dsifford, Zeno and I have been working on these updates for PRO for a while, and we wanted to port them to Classic as quickly as possible to bring the Dracula Classic theme closer to what we have in Dracula PRO.

dsifford · 2024-07-17T10:57:03Z

I do not agree here. I emailed zeno just now and I will say that if this is the practice that you are going to use moving forward then I'm forking this project and leaving. This is way too aggressive and is not in the spirit of OSS.

A theme with 7+ million installs requires a lot more thought when making changes like this. I found out about this after seeing 10+ negative review this morning in the marketplace.

dsifford · 2024-07-17T11:25:30Z

bun.lockb

@luxonauta Why would you even do this? I don't have bun and don't plan to download bun. Most contributors likely don't have bun. Please revert this.

dsifford · 2024-07-17T11:25:50Z

.editorconfig

Please revert this.

dsifford · 2024-07-17T11:26:33Z

.prettierrc.toml

-
-[[overrides]]
-  files = '*.{yml,yaml}'
-  [overrides.options]
-    tabWidth = 2


This change has nothing to do with the task here and should have been done in a separate PR.

dsifford · 2024-07-17T11:26:54Z

.vscode/settings.json

+    "files.eol": "\n",
+    "[md]": {
+        "editor.wordWrap": "bounded",
+        "editor.wordWrapColumn": 75
+    },
+    "[yml]": {
+        "editor.insertSpaces": true,
        "editor.renderWhitespace": "boundary",
+        "editor.tabSize": 2


This change has nothing to do with the task here and should have been done in a separate PR.

dsifford · 2024-07-17T11:27:56Z

src/dracula.yml

Because you changed the formatting rules, this changeset has become effectively non-reviewable. How do you expect people to see what you've actually done here?

luxonauta · 2024-07-17T11:40:17Z

Hey 👋🏻 @dsifford,

I understand your concern and would like to clarify a few points. 🧩

From our perspective, the repo seemed abandoned, with several issues and PRs dating back two years. Despite trying to email you and commenting on several PRs and Issues, we are still waiting to receive a response (which is not your obligation, and we understand and respect your time).

However, the last commit was on July 15, 2023. One year later, with several updates to the PRO, we decided in December last year to bring Classic closer to what we have in Dracula PRO to facilitate support for both and actively support them closely. 😅

I agree with you, and I'll exercise more caution and thoughtfulness when making changes. If you agree, I will also look for your review on changes like this one.

Our shared goal is to collaborate and improve the project constructively.

✅ Also, I'll make sure to open separate PRs with the changes you suggested here as comments.

dsifford · 2024-07-17T11:49:02Z

A few things here.

You have never emailed me.
A theme is not something that changes often. Issue count should not be treated as abandonment. Lots of those issues were single-user reports requesting jarring changes. I was waiting until those issue received traction before moving forward on them.
Dracula Pro is a fork of this repository. I'm flattered. But I do not agree with just taking the changes you made to that fork and blasting it back here without code review. This is not how software works. This feels to me like a hostile takeover and I very much do not appreciate almost a decade of my work getting steamrolled in one shot.

I understand that you're enthusiastic. That's very nice to see. But this is not how OSS works. Your changes here I do not agree with and unless they are rolled back and made in a way that is reviewable, then I'm forking this project and leaving.

@zenorocha I would love to hear your thoughts here. Do you agree with how this change was performed?

luxonauta · 2024-07-17T12:05:50Z

I'm sorry if there was any miscommunication. We attempted multiple times to reach out and get feedback on the PRs and issues, but I understand there may have been some misunderstandings. 😥

Our intention has always been to collaborate and improve the project constructively. I appreciate your work and dedication over the years, and I am committed to respecting and working together for the benefit of the project.

Also, the changes were made to contribute positively, and there was no intention to pressure or disrespect you.

✅ I am available to discuss and review any necessary changes to ensure we are all aligned.

dsifford · 2024-07-17T12:06:42Z

We attempted multiple times to reach out and get feedback on the PRs and issues,

Please show me.

luxonauta · 2024-07-17T12:13:57Z

I think it will be more beneficial to iterate together from now on than to continue this discussion.

✅ I am available to discuss and review any necessary changes to ensure we are all aligned. 😅

GoodbyeNJN · 2024-07-17T12:30:17Z

I think it will be more beneficial to iterate together from now on than to continue this discussion.

Since there has been quite a bit of negative feedback and the change does not follow the contribution process, the immediate priority should be to roll back the code and release a new version to avoid disrupting more users.

As for iteration and discussion, that is something that should be considered after this.

luxonauta · 2024-07-17T12:57:43Z

I reverted the recent changes and will open separate PRs for review. Thank you all for the discussion and feedback! 🧩

🌱 v2.25.0

c43214f

luxonauta self-assigned this Jul 17, 2024

luxonauta requested a review from dsifford July 17, 2024 01:47

This was referenced Jul 17, 2024

add editorActiveLineNumber.foreground #69

Closed

Initial ReScript Support #174

Closed

Fixed warning and info colors #198

Closed

Adds strike through font style and color #233

Closed

style: ✨ Update the gitDecoration and diffEditor #243

Closed

luxonauta added the enhancement label Jul 17, 2024

luxonauta marked this pull request as ready for review July 17, 2024 01:50

luxonauta mentioned this pull request Jul 17, 2024

Some kind of indication of currently selected item #252

Closed

luxonauta removed the request for review from dsifford July 17, 2024 02:05

luxonauta merged commit b517d25 into main Jul 17, 2024

luxonauta deleted the v2.25.0 branch July 17, 2024 02:06

This was referenced Jul 17, 2024

I need the 'Dracula Soft' theme, and I hope it won't be removed. #255

Closed

Is there any problem with the latest color scheme #254

Closed

dsifford reviewed Jul 17, 2024

View reviewed changes

This was referenced Jul 17, 2024

Workbench tree indent guidelines invisible in v2.25.0 #256

Closed

Does Dracula Pro include the old Dracula theme? #257

Closed

Highlighted text in UI elements is not visible #258

Closed

dracula locked as too heated and limited conversation to collaborators Jul 18, 2024

dracula deleted a comment from wenfangdu Jul 18, 2024

dracula deleted a comment from austinried Jul 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🌱 v2.25.0 #253

🌱 v2.25.0 #253

luxonauta commented Jul 17, 2024 •

edited

Loading

dsifford commented Jul 17, 2024

luxonauta commented Jul 17, 2024

dsifford commented Jul 17, 2024 •

edited

Loading

dsifford Jul 17, 2024

dsifford Jul 17, 2024

dsifford Jul 17, 2024

dsifford Jul 17, 2024

dsifford Jul 17, 2024

dsifford Jul 17, 2024

luxonauta commented Jul 17, 2024 •

edited

Loading

dsifford commented Jul 17, 2024 •

edited

Loading

luxonauta commented Jul 17, 2024

dsifford commented Jul 17, 2024

luxonauta commented Jul 17, 2024 •

edited

Loading

GoodbyeNJN commented Jul 17, 2024 •

edited

Loading

luxonauta commented Jul 17, 2024

🌱 v2.25.0 #253

🌱 v2.25.0 #253

Conversation

luxonauta commented Jul 17, 2024 • edited Loading

dsifford commented Jul 17, 2024

luxonauta commented Jul 17, 2024

dsifford commented Jul 17, 2024 • edited Loading

dsifford Jul 17, 2024

Choose a reason for hiding this comment

dsifford Jul 17, 2024

Choose a reason for hiding this comment

dsifford Jul 17, 2024

Choose a reason for hiding this comment

dsifford Jul 17, 2024

Choose a reason for hiding this comment

dsifford Jul 17, 2024

Choose a reason for hiding this comment

dsifford Jul 17, 2024

Choose a reason for hiding this comment

luxonauta commented Jul 17, 2024 • edited Loading

dsifford commented Jul 17, 2024 • edited Loading

luxonauta commented Jul 17, 2024

dsifford commented Jul 17, 2024

luxonauta commented Jul 17, 2024 • edited Loading

GoodbyeNJN commented Jul 17, 2024 • edited Loading

luxonauta commented Jul 17, 2024

luxonauta commented Jul 17, 2024 •

edited

Loading

dsifford commented Jul 17, 2024 •

edited

Loading

luxonauta commented Jul 17, 2024 •

edited

Loading

dsifford commented Jul 17, 2024 •

edited

Loading

luxonauta commented Jul 17, 2024 •

edited

Loading

GoodbyeNJN commented Jul 17, 2024 •

edited

Loading