Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test 20 - "NFSv3 root=dhcp DHCP IP:path" fails on debian #1901

Closed
LaszloGombos opened this issue Aug 13, 2022 · 8 comments · Fixed by #2496
Closed

Test 20 - "NFSv3 root=dhcp DHCP IP:path" fails on debian #1901

LaszloGombos opened this issue Aug 13, 2022 · 8 comments · Fixed by #2496
Labels
debian Issue tracker for the Debian distribution enhancement Issue adding new functionality good first issue Great issue for getting started with contributing to Dracut test Issues related to testing

Comments

@LaszloGombos
Copy link
Collaborator

LaszloGombos commented Aug 13, 2022

https://github.com/dracutdevs/dracut/blob/master/test/TEST-20-NFS/test.sh#L152 times out in when running on a Debian container. 4 NFS subtests pass, but the 5th times out.

The same test passes on the Fedora-latest and Arch containers, so the concern seems to be distro dependent.

@LaszloGombos LaszloGombos added the bug Our bugs label Aug 13, 2022
@LaszloGombos LaszloGombos added good first issue Great issue for getting started with contributing to Dracut enhancement Issue adding new functionality and removed bug Our bugs labels Oct 22, 2022
@LaszloGombos LaszloGombos added the test Issues related to testing label Nov 25, 2022
@LaszloGombos LaszloGombos changed the title "NFSv3 root=dhcp DHCP IP:path" fails on debian Test 20 - "NFSv3 root=dhcp DHCP IP:path" fails on debian May 10, 2023
@LaszloGombos LaszloGombos added the debian Issue tracker for the Debian distribution label May 10, 2023
@LaszloGombos
Copy link
Collaborator Author

Possibly a symptom of #2259 .

@LaszloGombos
Copy link
Collaborator Author

CC @bdrung for his possible feedback

@bdrung
Copy link
Contributor

bdrung commented Aug 15, 2023

The rpc user is named _rpc on Debian. Debian carries a patch: https://sources.debian.org/src/dracut/059-4/debian/patches/rpc-user/

@bdrung
Copy link
Contributor

bdrung commented Aug 19, 2023

Found this in the server.log:

jobs -rp
/sbin/init: 105: jobs: Illegal option -r

Reason: This works with bash but not with dash:

$ bash -c "jobs -rp"
$ dash -c "jobs -rp"
dash: 1: jobs: Illegal option -r

@LaszloGombos
Copy link
Collaborator Author

$ bash -c "jobs -rp"
$ dash -c "jobs -rp"
dash: 1: jobs: Illegal option -r

This can be resolved with the following patch, but I do not think this is enough to make the test pass on Debian

--- a/test/TEST-20-NFS/test.sh
+++ b/test/TEST-20-NFS/test.sh
@@ -415,7 +415,7 @@ test_setup() {
     )
     # Make server's dracut image
     "$basedir"/dracut.sh -l -i "$TESTDIR"/overlay / \
-        -m "dash rootfs-block debug kernel-modules watchdog qemu network network-legacy" \
+        -m "bash rootfs-block debug kernel-modules watchdog qemu network network-legacy" \
         -d "af_packet piix ide-gd_mod ata_piix ext4 sd_mod e1000 i6300esb" \
         --no-hostonly-cmdline -N \
         -f "$TESTDIR"/initramfs.server "$KVERSION" || return 1

bdrung added a commit to bdrung/dracut that referenced this issue Aug 21, 2023
Test 20 - "NFSv3 root=dhcp DHCP IP:path" fails on Debian with following
error message in `server.log`:

```
jobs -rp
/sbin/init: 105: jobs: Illegal option -r
```

The jobs parameter `-r` requires bash.

partial fix dracutdevs#1901
Signed-off-by: Benjamin Drung <[email protected]>
bdrung added a commit to bdrung/dracut that referenced this issue Aug 21, 2023
Test 20 - "NFSv3 root=dhcp DHCP IP:path" fails on Debian with following
error message in `server.log`:

```
jobs -rp
/sbin/init: 105: jobs: Illegal option -r
```

The jobs parameter `-r` requires bash.

Partially fixes dracutdevs#1901
Signed-off-by: Benjamin Drung <[email protected]>
bdrung added a commit to bdrung/dracut that referenced this issue Aug 21, 2023
Test 20 - "NFSv3 root=dhcp DHCP IP:path" fails on Debian with following
error message in `server.log`:

```
jobs -rp
/sbin/init: 105: jobs: Illegal option -r
```

The jobs parameter `-r` requires bash.

Partially fixes dracutdevs#1901
Signed-off-by: Benjamin Drung <[email protected]>
@bdrung
Copy link
Contributor

bdrung commented Aug 21, 2023

Thanks for the pointer. I got test 20 running on Debian with the following two patches:

bdrung added a commit to bdrung/dracut that referenced this issue Aug 21, 2023
Test 20 - "NFSv3 root=dhcp DHCP IP:path" fails on Debian with following
error message in `server.log`:

```
jobs -rp
/sbin/init: 105: jobs: Illegal option -r
```

The jobs parameter `-r` requires bash.

Partially fixes dracutdevs#1901
Signed-off-by: Benjamin Drung <[email protected]>
aafeijoo-suse pushed a commit that referenced this issue Aug 22, 2023
Test 20 - "NFSv3 root=dhcp DHCP IP:path" fails on Debian with following
error message in `server.log`:

```
jobs -rp
/sbin/init: 105: jobs: Illegal option -r
```

The jobs parameter `-r` requires bash.

Partially fixes #1901
Signed-off-by: Benjamin Drung <[email protected]>
@bdrung
Copy link
Contributor

bdrung commented Aug 22, 2023

Please reopen. We still need to include https://sources.debian.org/src/dracut/059-4/debian/patches/rpc-user/ in an upstreamable way.

@aafeijoo-suse
Copy link
Member

Auto-closed because the "partial fix" does not work as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debian Issue tracker for the Debian distribution enhancement Issue adding new functionality good first issue Great issue for getting started with contributing to Dracut test Issues related to testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants