Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes on 95suspend and 99base #1607

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Conversation

jmfernandez
Copy link
Contributor

This pull request fixes 95suspend module and a function from 99base, so resumes from hibernation using https://github.com/bircoph/suspend work in Gentoo.

Changes

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Fixes #

  • 95suspend module setup now also searches for /usr/lib64/suspend/resume and /usr/lib64/uswsusp/resume , which are relevant on distros like Gentoo.
  • label_uuid_to_dev now returns the unaltered input when it does not match any of the alternate ways to designate a device. Previously, the function was returning nothing, leading to potential failures in several places.

@github-actions github-actions bot added base Issues related to the base module modules Issue tracker for all modules resume Issues related to the resume module labels Sep 17, 2021
@stale
Copy link

stale bot commented Oct 17, 2021

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Oct 17, 2021
@stale stale bot closed this Oct 25, 2021
@haraldh haraldh reopened this Oct 25, 2021
@stale stale bot removed stale communication is stuck labels Oct 25, 2021
@haraldh
Copy link
Collaborator

haraldh commented Oct 26, 2021

Many thanks for your contribution!

Please fix your git commit messages according to https://github.com/dracutdevs/dracut/blob/master/docs/HACKING.md#commit-messages

@jmfernandez
Copy link
Contributor Author

I have just updated the commit messages. Hope they are now properly set.

Copy link
Collaborator

@johannbg johannbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to rephrase your commit messages description field to not exceed line a length of 80 as well as not to use a title case in the description.

@johannbg
Copy link
Collaborator

@jmfernandez hmm commisery is still unhappy.
change this commit msg
from
fix(base): added default device choice
to
fix(base): add default device choice

when the device is no one of the previous patterns,
substitute the empty default by the input,
to return the same input
Now resume binary is detected in case it is at
/usr/lib64/suspend (like it happens in Gentoo).
@jmfernandez
Copy link
Contributor Author

@jmfernandez hmm commisery is still unhappy. change this commit msg from fix(base): added default device choice to fix(base): add default device choice

Just done

@johannbg johannbg self-requested a review November 24, 2021 12:16
@johannbg johannbg enabled auto-merge (rebase) November 24, 2021 12:16
@johannbg johannbg merged commit c459373 into dracutdevs:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base Issues related to the base module modules Issue tracker for all modules resume Issues related to the resume module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants