-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes on 95suspend
and 99base
#1607
Conversation
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
Many thanks for your contribution! Please fix your git commit messages according to https://github.com/dracutdevs/dracut/blob/master/docs/HACKING.md#commit-messages |
I have just updated the commit messages. Hope they are now properly set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to rephrase your commit messages description field to not exceed line a length of 80 as well as not to use a title case in the description.
7b4a831
to
f587322
Compare
@jmfernandez hmm commisery is still unhappy. |
when the device is no one of the previous patterns, substitute the empty default by the input, to return the same input
Now resume binary is detected in case it is at /usr/lib64/suspend (like it happens in Gentoo).
Just done |
This pull request fixes
95suspend
module and a function from99base
, so resumes from hibernation using https://github.com/bircoph/suspend work in Gentoo.Changes
Checklist
Fixes #
95suspend
module setup now also searches for /usr/lib64/suspend/resume and /usr/lib64/uswsusp/resume , which are relevant on distros like Gentoo.label_uuid_to_dev
now returns the unaltered input when it does not match any of the alternate ways to designate a device. Previously, the function was returning nothing, leading to potential failures in several places.