Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: install util-linux-systemd and systemd-boot into openSUSE container #2427

Merged

Conversation

aafeijoo-suse
Copy link
Member

  • findmnt is installed by util-linux-systemd. E.g.:

https://github.com/dracutdevs/dracut/actions/runs/5424796254/jobs/10097178325#step:4:53

  • /usr/lib/systemd/boot/efi/linuxx64.efi.stub is installed by systemd-boot. E.g.:

https://github.com/dracutdevs/dracut/actions/runs/5424796254/jobs/10097178325#step:4:55

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

- `findmnt` is installed by `util-linux-systemd`
- `/usr/lib/systemd/boot/efi/linuxx64.efi.stub` is installed by `systemd-boot`
@github-actions github-actions bot added the test Issues related to testing label Jul 12, 2023
Copy link
Collaborator

@LaszloGombos LaszloGombos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LaszloGombos LaszloGombos added this to the dracut-060 milestone Jul 12, 2023
Copy link
Collaborator

@tblume tblume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/dracutdevs/dracut/blob/master/test/TEST-18-UEFI/test.sh#L74
expects the file in /usr/lib/gummiboot but the systemd-boot package installs it to:
/usr/lib/systemd/boot/efi.
Is the ci taking care of this?

@aafeijoo-suse
Copy link
Member Author

https://github.com/dracutdevs/dracut/blob/master/test/TEST-18-UEFI/test.sh#L74 expects the file in /usr/lib/gummiboot but the systemd-boot package installs it to: /usr/lib/systemd/boot/efi. Is the ci taking care of this?

That is to explicitly change the default path of the uefi stub (via --uefi-stub option).

dracut/dracut.sh

Lines 1528 to 1530 in dbdab2d

if ! [[ -s $uefi_stub ]]; then
uefi_stub="$dracutsysrootdir${systemdprefix}/lib/systemd/boot/efi/linux${EFI_MACHINE_TYPE_NAME}.efi.stub"
fi

Copy link
Collaborator

@tblume tblume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks.

LGTM

@aafeijoo-suse aafeijoo-suse merged commit 273e481 into dracutdevs:master Jul 24, 2023
74 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants