fix(test): running tests no longer requires to be root

[Henrik66]

After fd9cd02, tests no longer requires to be root. Being able to run VMs to run tests is required, but that should not imply root user.

Fixes #1147 and https://bugs.gentoo.org/298014

[LaszloGombos]

Thanks.

I will close #2217 in favor of this PR.

[aafeijoo-suse]

FWIW, this line would also have to be removed:

dracut/test/Makefile

Line 4 in 6af3fcf

@[ "$(shell id -u)" = 0 ] || { echo "'check' must be run as root! Please use 'sudo'."; exit 1; }

[Henrik66]

FWIW, this line would also have to be removed:

dracut/test/Makefile

Line 4 in 6af3fcf

@[ "$(shell id -u)" = 0 ] || { echo "'check' must be run as root! Please use 'sudo'."; exit 1; }

Thanks @aafeijoo-suse for the review.
Unfortunately, I do not understand what else needs to be removed as the line 4 of test/Makefile is already removed in this PR - see https://github.com/dracutdevs/dracut/pull/2429/files#diff-740cb5a1689091cb894445e46683c255e39689ccba1c6c63d8a8841c8df8817dL4 . Can you help me understand please ! Thanks !

[aafeijoo-suse]

FWIW, this line would also have to be removed:

dracut/test/Makefile

Line 4 in 6af3fcf

@[ "$(shell id -u)" = 0 ] || { echo "'check' must be run as root! Please use 'sudo'."; exit 1; }

Thanks @aafeijoo-suse for the review. Unfortunately, I do not understand what else needs to be removed as the line 4 of test/Makefile is already removed in this PR - see https://github.com/dracutdevs/dracut/pull/2429/files#diff-740cb5a1689091cb894445e46683c255e39689ccba1c6c63d8a8841c8df8817dL4 . Can you help me understand please ! Thanks !

Sorry, I missed that change somehow... it's all good

[LaszloGombos]

CC @bdrung for his possible feedback

[bdrung]

+1 from my side. I tested the patch from this PR plus #2484 successfully for the tests 01 02 03 04 on Debian and Ubuntu.

One caveat: The kernel on Ubuntu is only readable by root. So either make it readable or run as root. See https://launchpad.net/bugs/759725

[bdrung]

Please remove sudo from the Docker files in test/container/.