-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(base): correct handling of quiet in loginit #2451
base: master
Are you sure you want to change the base?
Conversation
dracut-lib.sh sets DRACUT_QUIET=no and passes this to loginit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, one can force push to https://github.com/bmwiedemann/dracut/tree/loginit and fix the commit message.
This would allow keeping the contribution credit to the original author and would help with the reviews also.
See also #1759 (comment)
The commit is still authored by Bernhard (see the git log), I only created a new PR importing his patch, which is the same as force pushing his branch (AFAIK). |
It is the same in terms of commit history (if and when it lands), but it is not the same in terms of our processes. Force pushing to the author's branch would keep not only the author of the commit, but also the author of the PR, which would allow your review approval to count towards the number of required approval. With this PR however, you are now the owner of the PR, which means that you can no longer review your own PR, even if you're not the author of the commit. Weird, but this is how it is setup. |
For me this is the only thing that really matters. |
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
dracut-lib.sh
setsDRACUT_QUIET
toyes
orno
and passes this tologinit
.Follow up to #2281 with the commit message fixed.
Checklist