Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(base): correct handling of quiet in loginit #2451

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aafeijoo-suse
Copy link
Member

dracut-lib.sh sets DRACUT_QUIET to yes or no and passes this to loginit.

Follow up to #2281 with the commit message fixed.

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

dracut-lib.sh sets DRACUT_QUIET=no
and passes this to loginit
@github-actions github-actions bot added modules Issue tracker for all modules base Issues related to the base module labels Jul 27, 2023
Copy link
Collaborator

@LaszloGombos LaszloGombos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, one can force push to https://github.com/bmwiedemann/dracut/tree/loginit and fix the commit message.

This would allow keeping the contribution credit to the original author and would help with the reviews also.

See also #1759 (comment)

@aafeijoo-suse
Copy link
Member Author

This would allow keeping the contribution credit to the original author and would help with the reviews also.

The commit is still authored by Bernhard (see the git log), I only created a new PR importing his patch, which is the same as force pushing his branch (AFAIK).

@LaszloGombos
Copy link
Collaborator

LaszloGombos commented Jul 27, 2023

which is the same as force pushing his branch (AFAIK).

It is the same in terms of commit history (if and when it lands), but it is not the same in terms of our processes.

Force pushing to the author's branch would keep not only the author of the commit, but also the author of the PR, which would allow your review approval to count towards the number of required approval.

With this PR however, you are now the owner of the PR, which means that you can no longer review your own PR, even if you're not the author of the commit. Weird, but this is how it is setup.

@aafeijoo-suse
Copy link
Member Author

which is the same as force pushing his branch (AFAIK).

It is the same in terms of commit history (if and when it lands), but it is not the same in terms of our processes.

For me this is the only thing that really matters.

@LaszloGombos LaszloGombos added this to the dracut-060 milestone Jul 29, 2023
@LaszloGombos LaszloGombos modified the milestones: dracut-060, dracut-061 Oct 30, 2023
@aafeijoo-suse aafeijoo-suse removed this from the dracut-061 milestone Nov 18, 2023
Copy link

stale bot commented Apr 22, 2024

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base Issues related to the base module modules Issue tracker for all modules stale communication is stuck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants