test(NFS): run either nfsv4 or nfsv3 tests

[Henrik66]

Run only nfsv4 tests unless nfs4 is not available

Checklist

• I have tested it locally
• I have reviewed and updated any documentation if relevant
• I am providing new code and test(s) for it

Fixes #2455

[LaszloGombos]

LGTM. Thanks. This helps having passing CI without compromising test coverage significantly.

[aafeijoo-suse]

isn't this check only for gentoo?

[LaszloGombos]

Yes, this check would only pass on Gentoo. In practice only the Gentoo container does not support NFSv4, so only Gentoo would run the NFSv3 tests by default.

I am not aware of how to test for this in a non-distribution specific way.

Perhaps one alternative is to introduce a command line option for tests and pass in in the test run command line if we only want to run NFSv3 or NFSv4 tests (or both).

[LaszloGombos]

This is a discussion meant to focus on what is running on CI (and not what can or should be tested outside of CI).
Currently Test 20 is longest running and most likely to timeout test on our CI (with 45 min timeout). Only enabled on Fedora.

To get to a state where CI is green and/or we enable this test for other distributions also, we need to either:

• make the test do less things and finish earlier (this is what this current PR proposes)
• increase timeout for the test (not a good option)
• parallelize subtests instead of running them sequentially (will take a while to come up with a way to do so)

CC @bdrung for visibility and feedback.

@bdrung what do you think of the goal of this PR and/or the way it is trying to do it ? Is there a better way to detect installed NFS versions in a distribution agonistic way ?

[bdrung]

The first question to answer is: Do we want to run only NFS v3 or v4 tests? How widely used is NFS v3 vs v4? If v3 is legacy and most of all systems use v4, I am fine with only running v4 tests (if v4 support is available). Other having tested both would be preferred.

[LaszloGombos]

The first question to answer is: Do we want to run only NFS v3 or v4 tests?
The current Gentoo test container only supports NFS v3. All other test containers support NFS v4.

I am fine with only running v4 tests (if v4 support is available). Other having tested both would be preferred.
Me too - this is what this PR is proposing already.