Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: do not run test container generation on forked repos by default #2460

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

Henrik66
Copy link
Contributor

@Henrik66 Henrik66 commented Jul 30, 2023

Container GitHub Action runs daily for dracutdevs developers. Every time dracut repo get's forked this daily github action runs on all forked repo's.

Some people know (and remember) to disable this action manually, but for the most this is just wasting significant resources as currently there is at east 300+ forked version of dracut on Github.

As suggested by @mwilck at #1865 (comment)

The workflow should be made conditional in some way.

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Fixes #1865

@github-actions github-actions bot added the github Issues related to .github label Jul 30, 2023
@LaszloGombos
Copy link
Collaborator

This is a good idea, but perhaps we should allow a way for a fork to opt-in running this action without forking the action file.
Perhaps we can use https://docs.github.com/en/actions/learn-github-actions/variables to opt-in for the action (on forked repo's also).

@Henrik66 Henrik66 marked this pull request as draft July 30, 2023 13:44
If CONTAINER Github variable set, reenable the github action
schedule.
@Henrik66 Henrik66 marked this pull request as ready for review July 30, 2023 14:21
Copy link
Collaborator

@LaszloGombos LaszloGombos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@aafeijoo-suse aafeijoo-suse merged commit 403f4e8 into dracutdevs:master Jul 31, 2023
76 of 83 checks passed
@Henrik66 Henrik66 deleted the c branch July 31, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github Issues related to .github
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container workflows fail in forks
3 participants