refactor(install): log about missing firmware only once #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to locate a firmware path under each of the firwaredirs parent directories, Dracut logs an error for every missing path. Instead, only log the error if the firmware path isn't found under any of the firmwaredirs. Signed-off-by: David Disseldorp <[email protected]>
LaszloGombos
approved these changes
Jul 30, 2023
| } | ||
| } | ||
| if (!found_this) { | ||
| /* firmware path was not found in any firmwaredirs */ | ||
| log_info("Missing firmware %s for kernel module %s", |
There was a problem hiding this comment.
Curious, why did you remove "Possible" from the log message ?
There was a problem hiding this comment.
I'd assumed that "possible missing firmware" indicated that the search was not (yet) exhaustive. I.e. it's not present in this firmware subdir, but might show up in a different one.
With the new logic we've checked all available firmwaredirs and can conclusively state that the firmware is not found.
Thanks for the review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to locate a firmware path under each of the firwaredirs parent directories, Dracut logs an error for every missing path. Instead, only log the error if the firmware path isn't found under any of the firmwaredirs.
Checklist