Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Make the purpose of fw_dir explicit #2462

Closed
wants to merge 1 commit into from
Closed

docs: Make the purpose of fw_dir explicit #2462

wants to merge 1 commit into from

Conversation

Zer0-One
Copy link

Updated documentation and usage text to make it explicit that fw_dir is only for CPU firmware.

I'm new to dracut, played around with it for a while today and got stuck trying to figure out why this configuration option wasn't working, until I read the script and realized it's working fine, it's just not named well.

@LaszloGombos
Copy link
Collaborator

CC @ddiss to help with the review

Copy link
Member

@aafeijoo-suse aafeijoo-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is also the firmware path for kernel modules.

Copy link
Contributor

@ddiss ddiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned by Antonio, fwdir is passed through to dracut-install via DRACUT_FIRMWARE_PATH and used to lookup kernel module firmware paths (e.g. modinfo i915 | grep "^firmware:"). The current usage looks fine.

@Zer0-One
Copy link
Author

I see. I was under the impression that it was for including firmware in the initramfs image.

@Zer0-One Zer0-One closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants