Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: do not run release generation on forked repos by default #2472

Closed
wants to merge 1 commit into from

Conversation

Henrik66
Copy link
Contributor

@Henrik66 Henrik66 commented Aug 5, 2023

If RELEASE Github variable set, or manual github action, than run the job as before.

After 9e1e924 automatic releases are generated even on forked repos.

Use the same idea as in 403f4e8 to stop this from happening.

Also make version information optional as the script is now able to compute the version.

@github-actions github-actions bot added the github Issues related to .github label Aug 5, 2023
Copy link
Collaborator

@LaszloGombos LaszloGombos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloGombos LaszloGombos added this to the dracut-060 milestone Aug 10, 2023
If RELEASE Github variable set, or a manual github action, than
run the job as before.

Also make version information optional as the script is now able
to compute the version.
@@ -8,13 +8,13 @@ on:
inputs:
tag:
description: "release version number (3 digits)"
required: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't have a lot of background in GitHub workflows, isn't a tag required to create a release?

run: bash ${GITHUB_WORKSPACE}/tools/release.sh ${{ inputs.tag }}

@LaszloGombos LaszloGombos modified the milestones: dracut-060, dracut-061 Oct 30, 2023
@aafeijoo-suse aafeijoo-suse removed this from the dracut-061 milestone Nov 18, 2023
@Henrik66 Henrik66 closed this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github Issues related to .github
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants