ci: add support for releasing with signed tags #2473
Conversation
tools/release.sh
Outdated
| @@ -46,7 +49,17 @@ git config user.name "Dracut Release Bot" | |||
| git config user.email "<>" | |||
There was a problem hiding this comment.
We might need to re-think what should be the commit user.name and user.email for signed tags.
Perhaps only set user.name and user.email if it is not already set
There was a problem hiding this comment.
To make this script more versatile so that it can be used by more people not just by repository admin, we should make taging optional and perhaps not tag by default.
There was a problem hiding this comment.
I'd say tags are quite a standard as of now. Dropping them would be counterproductive.
There was a problem hiding this comment.
Currently only the two admins (and no other user or bot or any kind of Github Action) that can tag (either signed or unsigned) a commit in the upstream repo. For everyone else, this script would fail (to push the tag).
Project members with only write access to the github repo do not have permission to push git tags (to any git branches).
|
LGTM. |
Henrik66
force-pushed
the
rel5
branch
4 times, most recently
from
2cca955
to
b89dbb9
Compare
Now that tools/release.sh supports all steps described in RELEASE.md, update RELEASE.md and point it to release.sh as the canonical manual way to make a release.
Now that tools/release.sh supports all steps described in RELEASE.md, update RELEASE.md and point it to release.sh as the canonical manual way to make a release.
Automates fix for #1850