fix(resume): fix including module in hostonly mode #2494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
modules
The grep introduced in commit e3a7112 does not work as intended. The resume module is always excluded in hostonly mode. Made this a bit more explicit with if/else so it is more clear what is going on. The in-line ||/&& makes the line really long and makes it more difficult to understand what is going on. Bug: #924 Signed-off-by: Andrew Ammerlaan <[email protected]>
3 tasks
|
Closing in favour of #2374 |
|
Gentle ping, I think this fixes quite a serious issue. We have this patch backported in our latest snapshot version in Gentoo: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=803a7e0b95164ddb661dee1448a4b19eceb09cc2 |
LaszloGombos
approved these changes
Nov 13, 2023
|
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
|
Resolved by: dracut-ng/dracut-ng@d2ff89e Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grep introduced in commit e3a7112 does not work as intended. The resume module is always excluded in hostonly mode.
Made this a bit more explicit with if/else so it is more clear what is going on. The in-line ||/&& makes the line really long and makes it more difficult to understand what is going on.
Bug: #924
Checklist