feat(install.d): allow using dracut in combination with ukify #2495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be simply accomplished with the KERNEL_INSTALL_INITRD_GENERATOR and KERNEL_INSTALL_UKI_GENERATOR variables. `60-ukify.install` looks for the initrd in the KERNEL_INSTALL_STAGING_AREA and then takes care of building the uki. This change makes it possible to use a configuration like this: /etc/kernel/install.conf layout=uki uki_generator=ukify initrd_generator=dracut Without this change this configuration will fail since dracut would also generate an uki instead of initrd, which will cause a problem in `60-ukify.install` since it can't find an initrd to use. Signed-off-by: Andrew Ammerlaan <[email protected]>
aafeijoo-suse
approved these changes
Aug 21, 2023
LaszloGombos
approved these changes
Aug 21, 2023
lnykryn
approved these changes
Aug 22, 2023
1 task
archlinux-github
pushed a commit
to archlinux/aur
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've already been told this is potentially controversial but hear me out hear please. Systemd-254 now ships with a
60-ukify.installkernel-install plugin. Currently this leads to a bit of an awkward situation where there are two potential paths to make an uki.KERNEL_INSTALL_UKI_GENERATORwould be the intended way to choose between these two but it is currently only respected in60-ukify.installbut not in50-dracut.install. This leads to weird problems if the user tries to configure this setting, potentially messing up the boot process on their system when both dracut and ukify try to make the uki (where the latter does not have an initrd to work with).This change prevents potential problems when these settings are set. If they aren't set (the default) we assume dracut is what we want to use for the initrd/uki (i.e. the same behaviour as before the change).
If you absolutely hate it, that's okay, we can just apply this patch downstream in Gentoo. But I'd like to offer it as a PR for consideration anyway.
Checklist