Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Full and Simple formats into separate Importers #73

Merged
merged 6 commits into from
Oct 4, 2024
Merged

Split Full and Simple formats into separate Importers #73

merged 6 commits into from
Oct 4, 2024

Conversation

caitmich
Copy link
Contributor

@caitmich caitmich commented Sep 4, 2024 •
edited
Loading

Summary

Separate Full and Simple formats into individual importers to maintain consistency with other upload integrations that accept multiple file types and have separate mappings for different file types

I assign all rights, including copyright, to any future Dradis
work by myself to Security Roots.

Check List

  • Added a CHANGELOG entry
  • Added specs

etdsoft
etdsoft reviewed Oct 3, 2024
View reviewed changes
spec/support/spec_macros.rb Outdated Show resolved Hide resolved
etdsoft
etdsoft reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@etdsoft etdsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting a sense of changes would have been easier if files were renamed instead of removed / added !

@caitmich caitmich merged commit acb82a4 into main Oct 4, 2024
@caitmich caitmich deleted the upload/multiple-importers branch October 4, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etdsoft etdsoft etdsoft left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caitmich @etdsoft