Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nydusify: fix oci media type handle #1163

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Mar 21, 2023

Bump nydus snapshotter v0.7.3 and bring some fixups:

  1. If the original image is already an OCI type, we should forcibly set the bootstrap layer to the OCI type.
  2. We need to append history item for bootstrap layer, to ensure the history consistency, see: https://github.com/distribution/distribution/blob/e5d5810851d1f17a5070e9b6f940d8af98ea3c29/manifest/schema1/config_builder.go#L136

Related PR: containerd/nydus-snapshotter#427, goharbor/acceleration-service#119

Bump nydus snapshotter v0.7.3 and bring some fixups:

1. If the original image is already an OCI type, we should forcibly set the bootstrap layer to the OCI type.
2. We need to append history item for bootstrap layer, to ensure the history consistency, see: https://github.com/distribution/distribution/blob/e5d5810851d1f17a5070e9b6f940d8af98ea3c29/manifest/schema1/config_builder.go#L136

Related PR: containerd/nydus-snapshotter#427, goharbor/acceleration-service#119

Signed-off-by: Yan Song <[email protected]>
@imeoer imeoer requested a review from a team as a code owner March 21, 2023 03:47
@imeoer imeoer requested review from bergwolf, liubin and liubogithub and removed request for a team March 21, 2023 03:47
@anolis-bot
Copy link
Collaborator

@imeoer , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/58088

@anolis-bot
Copy link
Collaborator

@imeoer , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@jiangliu jiangliu merged commit 82f3ee9 into dragonflyoss:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants