rafs: git rid of several unimplemented() #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangliu
requested review from
bergwolf,
liubin and
liubogithub
and removed request for
a team
|
@jiangliu , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/58185 |
The nydus-image check for v5 uses some unimplemented methods of InodeWrapper, which causes panicking at runtime. Fixes: dragonflyoss#1160 Signed-off-by: Jiang Liu <[email protected]>
jiangliu
force-pushed
the
inode-wrapper-unimplemented
branch
from
6916b91
to
818fe47
Compare
|
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/58187 |
imeoer
reviewed
Mar 21, 2023
| @@ -338,7 +338,7 @@ impl InodeWrapper { | |||
| match self { | |||
| InodeWrapper::V5(i) => i.i_mtime, | |||
| InodeWrapper::V6(i) => i.i_mtime, | |||
| InodeWrapper::Ref(_i) => unimplemented!(), | |||
| InodeWrapper::Ref(i) => i.get_attr().mtime, | |||
There was a problem hiding this comment.
Is it necessary to implement it in other methods like fn gid(&self), fn uid(&self)?
There was a problem hiding this comment.
That could be an following-on optimization:)
|
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
imeoer
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nydus-image check for v5 uses some unimplemented methods of InodeWrapper, which causes panicking at runtime.
Fixes: #1160