Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nydus-image: update documentation docs/nydus-image.md #1181

Merged
merged 1 commit into from
Mar 30, 2023
Merged

nydus-image: update documentation docs/nydus-image.md #1181

merged 1 commit into from
Mar 30, 2023

Conversation

jiangliu
Copy link
Collaborator

Update documentation docs/nydus-image.md.

@jiangliu jiangliu requested a review from a team as a code owner March 29, 2023 09:29
@jiangliu jiangliu requested review from liubin, luodw and adamqqqplay and removed request for a team March 29, 2023 09:29
@anolis-bot
Copy link
Collaborator

@jiangliu , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/62858

changweige
changweige reviewed Mar 29, 2023
View reviewed changes
docs/nydus-image.md Outdated Show resolved Hide resolved
changweige
changweige approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@changweige changweige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

adamqqqplay
adamqqqplay approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

liubin
liubin reviewed Mar 30, 2023
View reviewed changes
docs/nydus-image.md Outdated Show resolved Hide resolved
@adamqqqplay adamqqqplay added the documentation Improvements or additions to documentation label Mar 30, 2023
@jiangliu jiangliu force-pushed the nydus-image-doc branch 2 times, most recently from e5e0208 to abca4b2 Compare March 30, 2023 15:29
@anolis-bot
Copy link
Collaborator

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/63170

@jiangliu
nydus-image: update documentation docs/nydus-image.md
646f320 
Update documentation docs/nydus-image.md.

Signed-off-by: Jiang Liu <[email protected]>
@anolis-bot
Copy link
Collaborator

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/63171

@anolis-bot
Copy link
Collaborator

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/63172

@jiangliu jiangliu merged commit fb8db88 into dragonflyoss:master Mar 30, 2023
@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter❌ FAIL

Sorry, your test job failed. Please get the details in the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liubin liubin liubin left review comments

@adamqqqplay adamqqqplay adamqqqplay approved these changes

@changweige changweige changweige approved these changes

@luodw luodw Awaiting requested review from luodw luodw is a code owner automatically assigned from dragonflyoss/nydus-reviewers

Assignees
No one assigned
Labels
anolis_test_fail documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jiangliu @anolis-bot @liubin @changweige @adamqqqplay