Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support the arg batch-size for small chunks mergence for nydusify #1206

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

Desiki-high
Copy link
Member

@Desiki-high Desiki-high commented Apr 11, 2023

Add the batch-size arg for nydusify and the batch-size arg is new feature for nydus-image, which support merge small file chunks into one batch chunk.

That is the second part of work , the first part work is in nydus-snapshotter

This PR is related to #1202.

@anolis-bot
Copy link
Collaborator

@Desiki-high , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/65414

@anolis-bot
Copy link
Collaborator

@Desiki-high , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/65415

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@adamqqqplay adamqqqplay changed the title feat: support the arg batch-size for small chunks mergence for nydusify [WIP] feat: support the arg batch-size for small chunks mergence for nydusify Apr 11, 2023
@Desiki-high Desiki-high force-pushed the batchsize branch 3 times, most recently from eed55eb to af17aa5 Compare April 20, 2023 01:42
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #1206 (9c943cb) into master (ca8dab8) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1206      +/-   ##
==========================================
+ Coverage   45.01%   45.02%   +0.01%     
==========================================
  Files         126      126              
  Lines       37382    37382              
  Branches    37382    37382              
==========================================
+ Hits        16828    16832       +4     
+ Misses      19667    19661       -6     
- Partials      887      889       +2     

see 3 files with indirect coverage changes

@Desiki-high Desiki-high marked this pull request as ready for review April 20, 2023 01:49
@Desiki-high Desiki-high requested a review from a team as a code owner April 20, 2023 01:49
@Desiki-high Desiki-high requested review from bergwolf, liubin and liubogithub and removed request for a team April 20, 2023 01:49
@Desiki-high Desiki-high changed the title [WIP] feat: support the arg batch-size for small chunks mergence for nydusify feat: support the arg batch-size for small chunks mergence for nydusify Apr 20, 2023
@anolis-bot

This comment was marked as outdated.

@anolis-bot

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@Desiki-high Desiki-high added the enhancement New feature or request label Apr 20, 2023
@github-actions

This comment was marked as outdated.

@anolis-bot

This comment was marked as outdated.

@anolis-bot

This comment was marked as outdated.

@anolis-bot

This comment was marked as outdated.

@anolis-bot

This comment was marked as outdated.

@anolis-bot

This comment was marked as outdated.

@Desiki-high Desiki-high requested review from ccx1024cc and removed request for bergwolf, liubin and liubogithub April 20, 2023 12:54
@github-actions

This comment was marked as outdated.

@anolis-bot

This comment was marked as outdated.

@anolis-bot
Copy link
Collaborator

@Desiki-high , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/69609

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@imeoer imeoer merged commit a78db8b into dragonflyoss:master Apr 24, 2023
@Desiki-high Desiki-high deleted the batchsize branch April 25, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anolis_test_pass enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants