Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support more images for benchmark #1259

Merged
merged 4 commits into from
May 8, 2023

Conversation

Desiki-high
Copy link
Member

@Desiki-high Desiki-high commented May 5, 2023

To support more images in benchamrk on schedule.

1. move image arg from config.yml to runtime arg.

2. support more images in benchamrk.

image status workflow stable version test
wordpress wait the 80 port response 6.1.1
node node misc/benchmark/node/index.js & wait the 80 port response 19.8
python python -c 'print("hello")' 3.10.7
golang go run misc/benchmark/go/main.go 1.19.3
ruby ruby -e "puts \"hello\"" 3.1.3
java(amazoncorretto) javac msic/becnhmark/java/Main.java & java Main 8-al2022-jdk

@Desiki-high Desiki-high requested review from a team as code owners May 5, 2023 09:03
@Desiki-high Desiki-high requested review from liubin, liubogithub and hsiangkao and removed request for a team May 5, 2023 09:03
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #1259 (7591a41) into master (2f743c8) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 7591a41 differs from pull request most recent head fb66732. Consider uploading reports for the commit fb66732 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1259      +/-   ##
==========================================
+ Coverage   45.05%   45.07%   +0.01%     
==========================================
  Files         126      126              
  Lines       37395    37395              
  Branches    37395    37395              
==========================================
+ Hits        16850    16855       +5     
+ Misses      19656    19649       -7     
- Partials      889      891       +2     

see 2 files with indirect coverage changes

@Desiki-high Desiki-high force-pushed the feat-benchmark-images branch 11 times, most recently from 7591a41 to a63e53e Compare May 7, 2023 04:59
@Desiki-high Desiki-high changed the title [WIP]feat: support more images for benchmark feat: support more images for benchmark May 7, 2023
@Desiki-high
Copy link
Member Author

Next Wokr: test these images on schedule.

@anolis-bot
Copy link
Collaborator

@Desiki-high , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/71476

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

to support more images run on benchmark.

Signed-off-by: Yadong Ding <[email protected]>
add support for golang, java(amazoncorretto), ruby, and python.

Signed-off-by: Yadong Ding <[email protected]>
@imeoer
Copy link
Collaborator

imeoer commented May 8, 2023

Hi @Desiki-high, any example to preview the results of these images?

@anolis-bot
Copy link
Collaborator

@Desiki-high , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/71571

@imeoer imeoer reopened this May 8, 2023
@Desiki-high
Copy link
Member Author

Desiki-high commented May 8, 2023

Hi @Desiki-high, any example to preview the results of these images?

See the link in stable version test.

@Desiki-high
Copy link
Member Author

Hi @Desiki-high, any example to preview the results of these images?

See the link in stable version test.

You can see the image changes of workflows file in smoke.

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@Desiki-high
Copy link
Member Author

@imeoer Is there any problems else about this PR?

@imeoer imeoer merged commit 9d87631 into dragonflyoss:master May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants