fix some issue about the subcommand mount of nydusify #1319
Conversation
lihuahua123
requested review from
liubogithub,
changweige and
adamqqqplay
and removed request for
a team
|
@lihuahua123 , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/78129 |
Codecov Report
@@ Coverage Diff @@
## master #1319 +/- ##
==========================================
- Coverage 45.90% 45.68% -0.23%
==========================================
Files 123 123
Lines 37033 37254 +221
Branches 37033 37254 +221
==========================================
+ Hits 16999 17018 +19
- Misses 19139 19337 +198
- Partials 895 899 +4 |
|
@lihuahua123 , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@lihuahua123 , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/78142 |
|
@lihuahua123 Please don't submit a new one on next time, just use |
|
@lihuahua123 , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@lihuahua123 , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/78370 |
|
@lihuahua123 , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/78373 |
|
@lihuahua123 , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@lihuahua123 , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/78384 |
|
@lihuahua123 , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@lihuahua123 , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@lihuahua123 , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/78393 |
|
@lihuahua123 , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@imeoer ，the code has been refactored, is there some place needed to be modified? |
|
@lihuahua123 , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/78670 |
|
@lihuahua123 , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
- The `nydusify mount` subcomend don't require `--backend-type` and `--backend-config` options when the backend is registry.
- The methord to resolve it is we can get the `--backend-type` and `--backend-config` options from the docker configuration.
- Also, we have refractor the code of checker module in order to reuse the code
Signed-off-by: lihuahua123 <[email protected]>
|
@lihuahua123 , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/78798 |
|
@lihuahua123 , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
Relevant Issue (if applicable)
this is the solution of issue #1306
Details
we fix the bug, the nydusify
mountsubcommand will not need the--backend-typeand--backend-configoptions when the blobs of target image are all stored in the registry,Types of changes
Checklist