Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release): fix macos nydusd rust target #1324

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Jun 16, 2023

Can not use declare -A in macos shell.

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Can not use `declare -A` in macos shell.

Signed-off-by: killagu <[email protected]>
@killagu killagu requested review from a team as code owners June 16, 2023 06:54
@killagu killagu requested review from liubogithub, imeoer and hsiangkao and removed request for a team June 16, 2023 06:54
@anolis-bot
Copy link
Collaborator

@killagu , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/78836

@anolis-bot
Copy link
Collaborator

@killagu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/78841

@killagu
Copy link
Contributor Author

killagu commented Jun 16, 2023

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #1324 (e7c7b18) into master (9d87631) will increase coverage by 0.61%.
The diff coverage is 30.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1324      +/-   ##
==========================================
+ Coverage   45.07%   45.68%   +0.61%     
==========================================
  Files         126      123       -3     
  Lines       37395    37255     -140     
  Branches    37395    37255     -140     
==========================================
+ Hits        16854    17019     +165     
+ Misses      19655    19337     -318     
- Partials      886      899      +13     
Impacted Files Coverage Δ
api/src/error.rs 60.71% <0.00%> (ø)
api/src/http.rs 0.00% <0.00%> (ø)
api/src/http_handler.rs 55.12% <ø> (ø)
api/src/lib.rs 50.00% <ø> (ø)
builder/src/compact.rs 0.00% <0.00%> (ø)
builder/src/core/chunk_dict.rs 65.24% <ø> (ø)
builder/src/core/feature.rs 87.23% <ø> (ø)
builder/src/core/layout.rs 0.00% <0.00%> (ø)
builder/src/core/overlay.rs 0.00% <ø> (ø)
builder/src/core/v6.rs 32.45% <0.00%> (ø)
... and 39 more

... and 5 files with indirect coverage changes

@jiangliu
Copy link
Collaborator

Thanks for working on this, it should fix the failure in release github action.

@jiangliu jiangliu merged commit 3b71868 into dragonflyoss:master Jun 16, 2023
@anolis-bot
Copy link
Collaborator

@killagu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@anolis-bot
Copy link
Collaborator

@killagu , The CI test is completed, please check result:

Test CaseTest Result
nydus_ci❌ FAIL

Sorry, your test job failed. Please get the details in the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants