Nydusify: fix some bug about the subcommand mount of nydusify #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The `nydusify mount` subcomend don't require `--backend-type` and `--backend-config` options when the backend is registry.
- The methord to resolve it is we can get the `--backend-type` and `--backend-config` options from the docker configuration.
- Also, we have refractor the code of checker module in order to reuse the code
Signed-off-by: lihuahua123 <[email protected]>
lihuahua123
requested review from
jiangliu,
changweige and
adamqqqplay
and removed request for
a team
|
@lihuahua123 , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/79034 |
|
@lihuahua123 , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@lihuahua123 , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/79067 |
|
@lihuahua123 , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
this is the solution of issue #1306
Details
we fix the bug, the nydusify
mountsubcommand will not need the--backend-typeand--backend-configoptions when the blobs of target image are all stored in the registry,Types of changes
Checklist