-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service: refine block device implementation #1332
Conversation
@jiangliu , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/79328 |
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/79329 |
Codecov Report
@@ Coverage Diff @@
## master #1332 +/- ##
==========================================
- Coverage 45.68% 45.67% -0.01%
==========================================
Files 123 123
Lines 37255 37258 +3
Branches 37255 37258 +3
==========================================
Hits 17019 17019
- Misses 19337 19341 +4
+ Partials 899 898 -1
|
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/79335 |
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/79859 |
Refine block device implementation by: 1) limit number of blocks to u32::MAX 2) rename BlockDevice::new() to new_with_cache_manager() 3) introduce another implementation of BlockDevice::new() Signed-off-by: Jiang Liu <[email protected]>
The rafs core assume meta data is 4k-aligned, so it fails to inspect raw block image generated from tarfs images, which are 512-bytes aligned. Signed-off-by: Jiang Liu <[email protected]>
error[vulnerability]: `openssl` `X509VerifyParamRef::set_host` buffer over-read ┌─ /github/workspace/Cargo.lock:122:1 │ 122 │ openssl 0.10.48 registry+https://github.com/rust-lang/crates.io-index │ --------------------------------------------------------------------- security vulnerability detected │ = ID: RUSTSEC-2023-0044 = Advisory: https://rustsec.org/advisories/RUSTSEC-2023-0044 = When this function was passed an empty string, `openssl` would attempt to call `strlen` on it, reading arbitrary memory until it reached a NUL byte. = Announcement: sfackler/rust-openssl#1965 = Solution: Upgrade to >=0.10.55 Signed-off-by: Jiang Liu <[email protected]>
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/79871 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Refine block device implementation by:
Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.