[WIP] nydus-image: fix unpack from specify blob dir #1338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the panic when user specify `--blob-dir` on unpack:
```
$ nydus-image unpack --bootstrap /path/to/bootstrap \
--blob-dir /path/to/blobs \
--output /path/to/oci.tar
Error: fail to unpack
Caused by:
both blob path or blob backend config are not specified
```
Signed-off-by: Yan Song <[email protected]>
imeoer
requested review from
jiangliu,
changweige and
adamqqqplay
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #1338 +/- ##
==========================================
- Coverage 45.68% 45.63% -0.06%
==========================================
Files 123 123
Lines 37266 37305 +39
Branches 37266 37305 +39
==========================================
- Hits 17026 17024 -2
- Misses 19342 19383 +41
Partials 898 898
|
|
Really helpful fix, I thought it was a problem with my usage, so I could only use the --blob parameter instead of --blob-dir. Thanks a lot! |
jiangliu
reviewed
Jun 27, 2023
| None => Self::get_backend(matches, "unpacker").ok(), | ||
| None => { | ||
| Some(BlobFactory::new_backend( | ||
| config.backend.as_ref().unwrap(), |
There was a problem hiding this comment.
Is it safe to unwrap() here? Or should we check and return error code instead?
|
Otherwise LGTM! |
6 tasks
|
Fixed in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the panic when user specify
--blob-diron unpack:Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.