-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deprecated docker field leads to failure of nydusify check #1349
fix: deprecated docker field leads to failure of nydusify check #1349
Conversation
@ccx1024cc , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/83049 |
Codecov Report
@@ Coverage Diff @@
## master #1349 +/- ##
=======================================
Coverage 45.70% 45.70%
=======================================
Files 123 123
Lines 37287 37287
Branches 37287 37287
=======================================
Hits 17043 17043
- Misses 19347 19348 +1
+ Partials 897 896 -1 |
@ccx1024cc , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/83050 |
d966a8d
to
ba0f9a7
Compare
@ccx1024cc , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/83052 |
@ccx1024cc , The CI test is completed, please check result:
Sorry, your test job failed. Please get the details in the link. |
@ccx1024cc , The CI test is completed, please check result:
Congratulations, your test job passed! |
@ccx1024cc , The CI test is completed, please check result:
Sorry, your test job failed. Please get the details in the link. |
`NydusImage.Config.Config.ArgsEscaped` is present only for legacy compatibility with Docker and should not be used by new image builders. Nydusify (1.6 and above) ignores it, which is an expected behavior. This pr ignores comparision of it in nydusify checking, which leads to failure. Signed-off-by: 泰友 <[email protected]>
ba0f9a7
to
0698b0c
Compare
@ccx1024cc , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/83818 |
@ccx1024cc , The CI test is completed, please check result:
Congratulations, your test job passed! |
Details
NydusImage.Config.Config.ArgsEscaped
is present only for legacy compatibility with Docker and should not be used by new image builders. Nydusify (1.6 and above) ignores it, which is an expected behavior.This pr ignores comparision of it in nydusify checking, which leads to failure.
Types of changes
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.Spec
image-spec