Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: reduce the number of times the codecov tool sends comments #1350

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

adamqqqplay
Copy link
Member

Relevant Issue (if applicable)

containerd/nydus-snapshotter#503

Details

This patch alleviates the problem that codecov frequently sending emails to users when PR is updated.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

This patch alleviates the problem that codecov frequently sending
emails to users when PR is updated.

Signed-off-by: Qinqi Qu <[email protected]>
@adamqqqplay adamqqqplay requested a review from imeoer July 6, 2023 03:36
@adamqqqplay adamqqqplay requested a review from a team as a code owner July 6, 2023 03:36
@adamqqqplay adamqqqplay requested review from liubogithub and changweige and removed request for a team July 6, 2023 03:36
@anolis-bot
Copy link
Collaborator

@adamqqqplay , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/83117

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #1350 (8bfb26d) into master (7d5cb1a) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1350      +/-   ##
==========================================
- Coverage   45.70%   45.69%   -0.01%     
==========================================
  Files         123      123              
  Lines       37287    37287              
  Branches    37287    37287              
==========================================
- Hits        17043    17040       -3     
- Misses      19347    19348       +1     
- Partials      897      899       +2     

see 3 files with indirect coverage changes

@jiangliu jiangliu merged commit 6264367 into dragonflyoss:master Jul 6, 2023
24 checks passed
@anolis-bot
Copy link
Collaborator

@adamqqqplay , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants