-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change a new nydus image for ci test #1371
Conversation
@yqleng1987 , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/84231 |
@yqleng1987 , The CI test is completed, please check result:
Congratulations, your test job passed! |
@@ -1,7 +1,7 @@ | |||
load "${BATS_TEST_DIRNAME}/common_tests.sh" | |||
|
|||
setup() { | |||
nydus_rafs_image="nydus-anolis-registry.cn-hangzhou.cr.aliyuncs.com/nydus_test/bldlinux:v0.1-rafs-v6-lz4" | |||
nydus_rafs_image="docker.io/hsiangkao/bldlinux:v0.1-rafs-v6-lz4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am worried about the QPS limitation from dockerhub which can break the CI test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firstly, the test machine is located in Europe.
Secondly, the other 2 test cases below use the image in dockerhub, which is more stable than this test case which uses the image in hangzhou, based on the previous testing history.
https://github.com/dragonflyoss/image-service/blob/master/tests/bats/run_container_with_rafs.bats
https://github.com/dragonflyoss/image-service/blob/master/tests/bats/run_container_with_zran.bats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yqleng1987 I just uploaded a image to the github repository: ghcr.io/dragonflyoss/image-service/bldlinux:v0.1-rafs-v6-lz4
, could you try it to be able to use in CI?
The network is not stable when pulling the old image, which may result in ci test failure, so use the new image instead. Signed-off-by: Yiqun Leng <[email protected]>
@yqleng1987 , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/84307 |
@yqleng1987 , The CI test is completed, please check result:
Congratulations, your test job passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The network is not stable when pulling the old image, which may result in ci test failure, so use the new image instead.
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.