Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup nydusctl umount argument usage #1377

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Conversation

cntianci
Copy link
Contributor

@cntianci cntianci commented Jul 18, 2023

Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@cntianci cntianci requested a review from a team as a code owner July 18, 2023 03:47
@cntianci cntianci requested review from bergwolf, jiangliu and changweige and removed request for a team July 18, 2023 03:47
@anolis-bot
Copy link
Collaborator

@cntianci , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/85309

@cntianci cntianci changed the title \ fixup nydusctl umount argument usage Jul 18, 2023
@anolis-bot
Copy link
Collaborator

@cntianci , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/85312

@cntianci cntianci closed this Jul 18, 2023
@anolis-bot
Copy link
Collaborator

@cntianci , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/85313

@anolis-bot
Copy link
Collaborator

@cntianci , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@cntianci , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@cntianci , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@cntianci cntianci reopened this Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #1377 (02afb8f) into master (be52ebd) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1377   +/-   ##
=======================================
  Coverage   46.16%   46.17%           
=======================================
  Files         122      122           
  Lines       37913    37918    +5     
  Branches    37913    37918    +5     
=======================================
+ Hits        17504    17508    +4     
  Misses      19489    19489           
- Partials      920      921    +1     
Impacted Files Coverage Δ
builder/src/core/v5.rs 76.64% <0.00%> (+0.24%) ⬆️
src/bin/nydusctl/main.rs 0.56% <0.00%> (+<0.01%) ⬆️

... and 3 files with indirect coverage changes

@jiangliu jiangliu merged commit 0c01dac into dragonflyoss:master Jul 25, 2023
45 of 46 checks passed
@cntianci cntianci deleted the fixup branch July 25, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants