-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add seekable method for TarReader use to determine whether the current reader supports seek #1411
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1411 +/- ##
=======================================
Coverage 46.43% 46.43%
=======================================
Files 123 123
Lines 38644 38655 +11
Branches 38644 38655 +11
=======================================
+ Hits 17943 17951 +8
- Misses 19727 19730 +3
Partials 974 974
|
@zyfjeff , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/90733 |
builder/src/tarball.rs
Outdated
TarReader::BufReaderInfoSeekable(b) => b.seek(pos), | ||
_ => Err(enosys!("seek() not supported!")), | ||
TarReader::File(f) => { | ||
debug_assert!(seekable); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not recommend using debug_assert!
, as this may cause inconsistent binary behavior between debug and release builds (although this would not happen here).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, use assert!
…t reader supports seek Signed-off-by: zyfjeff <[email protected]>
@zyfjeff , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/90741 |
retest |
@zyfjeff , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/90757 |
@zyfjeff , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/90760 |
…t reader supports seek Signed-off-by: zyfjeff <[email protected]>
Relevant Issue (if applicable)
#1410
Details
Add seekable method for TarReader use to determine whether the current reader supports seek
Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.